Pages: 1 2 3 [4] 5 6 7 ... 10
31
« Last post by Tanker66 on January 13, 2025, 05:58:56 AM »
Hello, So, what is the best current production sound board for the TCB? Thanks!
32
« Last post by LukeZ on January 05, 2025, 01:06:53 PM »
Thanks for testing Chris. As far as I can tell from your screenshots, the application looks the same on your hi-res screen as it does on mine, so that appears to be finally fixed. I've seen screenshots other users have posted before this update, and you're right, the text was all messed up and nearly unusable. It's shameful that this problem took so many years to resolve. I am extremely grateful to you for taking it upon yourself to work on this, for the benefit of everyone. I see from your commits on GitHub that you started tinkering a year ago this month! I know you must have spent a great deal of time and effort; just getting Qt going is a major undertaking.
I feel confident enough in these alterations now that I've accepted your pull request and the changes have been merged into the source repo.
I've also created an official new release (numbered 0.94 as you suggested), and it is posted to the Downloads page or available for updating within any prior version of OP Config.
Once again thanks for all your help. If you come across anything else that needs attention, just let me know.
33
« Last post by FuzzyJack on January 04, 2025, 10:33:59 AM »
As far as I can tell all you have slightly increased the Blitz Timer and remove the specific call to SendInit().
Previously it was a bit strange that it setup the timers and then called SendInit() and the first thing the Blitz timer did was call it agian and I wasn't totally sure why it needed to do that. Now without calling SendInit() delliberately it seems to connect perfectly every time now which is soo much nicer!
It also connects ok from the snoop still as well so nothing changed there. It seems to work brilliantly so that's a good improvement.
As for the High DPI and the screens themselves I am using an old MacBook Pro (2015) with a Retina display running at 2880 x 1800 and with the last few tweaks you have made the fields look pretty good.
Obviously with the older version and the non High DPI setting the screen was all over the place with fields overlapping and text fields being output in all sorts of font sizes and it was mostly unusable like that. With the settings now in Qt6 it looks really good.
I've attached shots of each screen just for reference. They all look really good to me.
I need to build a small conversion board from my current Henglong Sherman wiring now to interface with the TCB (I have a 360 degree rotation slip ring to the turret connections so I don't want to directly rewire the Airsoft and will do it with a small PCB and some XH/PH connnectors instead so that it is reversible. Once I have that sorted and wired in I will do some more testing and see if there is anything else I can think of.
Chris.
34
« Last post by LukeZ on January 02, 2025, 03:13:22 PM »
Hi Chris, I made a very slight change to the serial connection process which seems on my end at least to improve the reliability of connections to the board. I've committed them to your repo, if you want to test it out.
35
« Last post by LukeZ on January 02, 2025, 08:16:55 AM »
Thanks for confirming, and also for fixing the Hex downloader. Since we're putting them now in the user's Downloads folder, it seems that we should put them in a folder with a better name than just "firmware," so I've changed that to OpenPanzer.
That was a good idea about InnoSetup removing those other files, and indeed that wasn't hard to do. I've gone ahead and had it remove both the Assistant cache as well as the hex downloads. I guess one could go either way on the second one, but if it were me I'd rather not have junk files laying around. Every hex can easily be downloaded from the website so it's not like the user can't recover them, even without OP Config.
I've committed these changes to your fork and a few other minor things.
If you make any other changes go ahead and also commit them to your fork rather than the source OP Config repo, and when it's stable I'll pull in the entire request.
Right now my setup is really crazy as I've kept the old version of Qt and everything else alongside the new, for dev purposes. But I'll clean it all up when we do the final over-write.
Are there other issues that we should address? I know there is the flakiness of the serial connection, that has always been an issue and I can revisit it but I don't think it is affected one way or the other by the upgrade to Qt6.
I should also say that I don't actually have a high-resolution monitor, so I can't really see what the program looks like in regards to the problem we were originally trying to fix. I assume it does look better?
36
« Last post by FuzzyJack on January 02, 2025, 06:22:14 AM »
Good find Luke,
Yes I can confirm that it works fine for me and creates the cache files in the AppData folder structure for my user as it should.
The firmware download still tries to use Program files of course but we should be able to use the QStandardPaths to find something like the downloads folder to do that as well and problem solved!
e.g.
QStandardPaths::DownloadLocation 14 Returns a directory for user's downloaded files. This is a generic value. If no directory specific for downloads exists, a sensible fallback for storing user documents is returned.
I've tweaked the SaveWebHexToLocal function to use the "writableLocation" of the Downloads folder and it works fine :-)
It still creates the firmware directory if it doesn't exist and deletes an existing copy of the file before saving it. Obviously once it is in the downloads and used it is the responsbility of the user to delete it afterwards if they want to.
Which does beg the question of whether an uninstall should leave the AppData/Local/OpenPanzer folder hanging around or not so I might see if the InnoSetup uninistaller would be able to remove that as part of the uninstall. Probably leave the downloads alone though.
37
« Last post by LukeZ on January 02, 2025, 06:04:41 AM »
The problem with %QDesktopServices::AppDataLocation% is that it appears to be deprecated so it's hard to test what exactly it thinks that should be. No doubt it's using the new QStandardPaths collection but the documentation hasn't been updated so that adds to the confusion.
But I had some ideas after sleeping on it. I tried a few things and got it working, and only after I got it working, did I find in the documentation where it would have told me how to get it working.
If we empty the value in the XML cache directory element like this: <cacheDirectory base="collection"></cacheDirectory>, or if we just remove it entirely (the documentation implies it's optional), then regenerate our .qch and .qhc files using the createqhcp.bat script of course, amazingly now Assistant works. But there is no subdirectory created in Program Files, I had to search high and low for where it had put the cache file, which turns out to be: C:\Users\*username*\AppData\Local\QtProject\Assistant\
That's definitely a better place to put it, though not very intuitive.
Then I got to wondering why I had that strange attribute base="collection" in the XML tag. So I removed that attribute but left the rest, like this: <cacheDirectory>OpenPanzer/OPConfig</cacheDirectory> ...and then regenerated and tried again. Guess what, now it sticks the cache file here: C:\Users\*username*\AppData\Local\OpenPanzer\OPConfig\
Exactly what we want. I still didn't understand why that fixed it, but knowing what the problem was, I was able to find the answer. If we go to the same link I provided before, and scroll down even further, there is actually information about this base attribute. If it is specified as "collection", that tells it to create the cache file in a directory relative to where the original collection resides, which in our case is program files. If set to "default" or nothing, it goes to AppDataLocation. Not sure why I had used the first option, but that was ten years ago, what did I know then!
So that is cleared up. I committed a change to your repo, I would be grateful if you could test to verify that it really works!
38
« Last post by FuzzyJack on January 02, 2025, 05:13:15 AM »
According to the docs you can specify the cache folder location in the configuration for the collection and QtAssistant is supposed to create the cache in the location supplied by %QDesktopServices::AppDataLocation%. https://doc.qt.io/qt-6/assistant-custom-help-viewer.htmlAt the moment the cache is set to: <title>OP Config Help</title> <applicationIcon>images/helpicon_32.png</applicationIcon> <cacheDirectory base="collection">OpenPanzer/OPConfig</cacheDirectory> But it is definitely not trying to create it in the appdatalocation unless something is overriding it? Obviously another workaround for this issue (and the hex download) is to run op-config as Administrator it can then do what it needs to to create the cache files and the firmware folder without needing to manually grant permissions. There must be a way to get the Qt App to work in a more security friendly way though.
39
« Last post by FuzzyJack on January 02, 2025, 04:58:42 AM »
Damn... Maybe I didn't try the help file from the proper install or something as I just reinstalled and tried it again and I get a failure too. I could have sworn I checked the help after running the install but maybe I did it without running an uninstall first or something and already had permissions or an old copy of the folder? Not sure.
Attached the error I got and if I grant write permissions to All Users on the help_files folder and restart then it can create the required files and works ok.
I must have missed it first time.
40
« Last post by FuzzyJack on January 02, 2025, 04:46:54 AM »
Pages: 1 2 3 [4] 5 6 7 ... 10
|